Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change forwarder proxy bytecode to ERC-1167 #2281

Merged
merged 5 commits into from
Feb 13, 2021
Merged

Change forwarder proxy bytecode to ERC-1167 #2281

merged 5 commits into from
Feb 13, 2021

Conversation

fubuloubu
Copy link
Member

What I did

fixes: #2269

How I did it

Copy some stuff

How to verify it

  • Manual inspection
  • Deploy to Etherscan and verify proxy working

Description for the changelog

Updated forwarder proxy bytecode to ERC-1167 compliance

Cute Animal Picture

cute kitty

@fubuloubu fubuloubu changed the title Change forwarder proxy bytecode to ERC-1167 [DRAFT] Change forwarder proxy bytecode to ERC-1167 Jan 23, 2021
@codecov-io
Copy link

codecov-io commented Jan 23, 2021 •
edited
Loading

Codecov Report

Merging #2281 (b1bf214) into master (4ac9e49) will increase coverage by 0.34%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2281      +/-   ##
==========================================
+ Coverage   85.44%   85.79%   +0.34%     
==========================================
  Files          84       85       +1     
  Lines        8591     8546      -45     
  Branches     2075     2036      -39     
==========================================
- Hits         7341     7332       -9     
+ Misses        748      730      -18     
+ Partials      502      484      -18
Impacted Files Coverage Δ
vyper/functions/functions.py 89.25% <85.71%> (-0.17%) ⬇️
vyper/parser/parser.py 81.17% <0.00%> (-6.06%) ⬇️
vyper/parser/global_context.py 71.83% <0.00%> (-5.95%) ⬇️
vyper/context/types/meta/event.py 77.58% <0.00%> (-5.03%) ⬇️
vyper/compiler/output.py 97.08% <0.00%> (-2.92%) ⬇️
vyper/signatures/sig_utils.py 97.14% <0.00%> (-2.86%) ⬇️
vyper/parser/context.py 93.25% <0.00%> (-2.79%) ⬇️
vyper/parser/parser_utils.py 79.77% <0.00%> (-1.65%) ⬇️
vyper/compiler/phases.py 94.44% <0.00%> (-1.07%) ⬇️
vyper/parser/expr.py 77.18% <0.00%> (-0.64%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac9e49...b1bf214. Read the comment docs.

@iamdefinitelyahuman
Copy link
Contributor

I believe the logic here is good to go, just some tests need updating.

@fubuloubu fubuloubu mentioned this pull request Feb 1, 2021
Closed
@banteg banteg mentioned this pull request Feb 8, 2021
Closed
@fubuloubu fubuloubu self-assigned this Feb 9, 2021
@fubuloubu fubuloubu force-pushed the refactor/forwarder-erc-1167 branch 3 times, most recently from f80c393 to 0a2bbd1 Compare February 13, 2021 03:45
@fubuloubu fubuloubu changed the title [DRAFT] Change forwarder proxy bytecode to ERC-1167 Change forwarder proxy bytecode to ERC-1167 Feb 13, 2021
@fubuloubu fubuloubu force-pushed the refactor/forwarder-erc-1167 branch from 0a2bbd1 to b1bf214 Compare February 13, 2021 03:57
@fubuloubu
Copy link
Member Author

It works!
https://ropsten.etherscan.io/address/0xC2fD8102A9d46d332acFdF28e725BC2a2375B70E#code

@fubuloubu fubuloubu mentioned this pull request Feb 13, 2021
Merged
@iamdefinitelyahuman iamdefinitelyahuman merged commit fbd6880 into vyperlang:master Feb 13, 2021
@fubuloubu fubuloubu deleted the refactor/forwarder-erc-1167 branch February 13, 2021 21:08
@fubuloubu fubuloubu mentioned this pull request Apr 5, 2021
Closed
@charles-cooper charles-cooper mentioned this pull request Jun 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacqueswww jacqueswww jacqueswww left review comments

@iamdefinitelyahuman iamdefinitelyahuman iamdefinitelyahuman approved these changes

Assignees

@fubuloubu fubuloubu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VIP: change create_forwarder_to to ERC-1167
4 participants
@fubuloubu @codecov-io @iamdefinitelyahuman @jacqueswww